Skip to content

DOCS-3472: Add documentation for Viam Apps #4335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

promptless[bot]
Copy link
Contributor

@promptless promptless bot commented May 21, 2025

Main changes are here: https://deploy-preview-4335--viam-docs.netlify.app/operate/control/viam-applications/

TODO:

  • use a CNAME record to "hide" URL

Created comprehensive documentation for the new Viam Single Page Apps feature (APP-7529) that allows users to upload single page applications and access them via appname.publicnamespace.viamapps.com with hosting, authentication, and boilerplate logic handled by Viam. Added a main reference page, updated module configuration and naming documentation.

Copy link

netlify bot commented May 21, 2025

Deploy Preview for viam-docs ready!

Name Link
🔨 Latest commit c95668c
🔍 Latest deploy log https://app.netlify.com/projects/viam-docs/deploys/6879198f6d291a00081c3b1d
😎 Deploy Preview https://deploy-preview-4335--viam-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 26 (🔴 down 3 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@viambot
Copy link
Member

viambot commented May 21, 2025

👋 Thanks for contributing! A reviewer will look at it on the next working day!

@npentrel npentrel changed the title docs: Add documentation for Viam Single Page Apps DOCS-3472: Add documentation for Viam Single Page Apps May 21, 2025
@npentrel npentrel marked this pull request as draft May 21, 2025 11:48
@npentrel npentrel force-pushed the docs-update-a3ce53e9-1afa-4e47-8e40-7a3998fb4c11-20250521-113348 branch 4 times, most recently from d89e2d9 to dd2973a Compare May 23, 2025 20:55
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't looked at this yet - do not review yet

@npentrel npentrel force-pushed the docs-update-a3ce53e9-1afa-4e47-8e40-7a3998fb4c11-20250521-113348 branch from dd2973a to 02c4c41 Compare May 23, 2025 21:03
@npentrel
Copy link
Collaborator

@npentrel npentrel force-pushed the docs-update-a3ce53e9-1afa-4e47-8e40-7a3998fb4c11-20250521-113348 branch 2 times, most recently from 11f6861 to 6b62ff7 Compare May 26, 2025 17:04
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated but doesn't hurt to keep it here

@npentrel npentrel force-pushed the docs-update-a3ce53e9-1afa-4e47-8e40-7a3998fb4c11-20250521-113348 branch from 03ef06e to e226798 Compare May 27, 2025 11:15
@npentrel npentrel marked this pull request as ready for review May 27, 2025 11:16
@npentrel
Copy link
Collaborator

I have moved the tutorial update to #4340. This PR is ready for review

@npentrel npentrel force-pushed the docs-update-a3ce53e9-1afa-4e47-8e40-7a3998fb4c11-20250521-113348 branch 5 times, most recently from 412fb4a to c12df67 Compare May 27, 2025 11:29
@npentrel npentrel requested a review from bashar-515 May 27, 2025 11:30
@npentrel npentrel mentioned this pull request May 27, 2025
1 task
@npentrel npentrel changed the title DOCS-3472: Add documentation for Viam Single Page Apps DOCS-3472: Add documentation for Viam Apps May 27, 2025
weight: 5
layout: "docs"
type: "docs"
description: "Create and deploy custom web interfaces for your machines as single-page applications without managing hosting and authentication."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed on Slack- I think we should remove any mention of "single-page"


### Access machines from your app

Viam apps provide access to a machine by placing its API key in your local storage.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API Key ends up getting stored as a cookie, not in localStorage or sessionStorage.

} = JSON.parse(Cookies.get(machineId)!));
```

For developing your app on localhost, add the same information to your browsers local storage.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is getting removed, right? If so, we'll make sure to ping you when this ticket is done so this doc can be updated.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, we won't publish until that ticket is ready. I just thought we were more eager to get this live than we apparently are

<!-- prettier-ignore -->
| Property | Type | Description |
| ------------ | ------ | ----------- |
| `name` | string | The name of your application, which will be a part of the app's URL (`name_publicnamespace.viamapplications.com`). For more information on valid names see [](/operate/reference/naming-modules/#valid-application-identifiers). |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This didn't render anything for me in the preview.


## FAQ

### Can I use a custom domain?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NickPPC can you re-review this part?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's good


## FAQ

### Can I use a custom domain?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's good

@npentrel npentrel force-pushed the docs-update-a3ce53e9-1afa-4e47-8e40-7a3998fb4c11-20250521-113348 branch from 37312f9 to 4ea5250 Compare July 17, 2025 13:42
npentrel and others added 2 commits July 17, 2025 16:01
Co-authored-by: Nicolas Palpacuer <[email protected]>
Co-authored-by: Nicolas Palpacuer <[email protected]>
@npentrel npentrel force-pushed the docs-update-a3ce53e9-1afa-4e47-8e40-7a3998fb4c11-20250521-113348 branch from 2e76007 to 50b6524 Compare July 17, 2025 14:28
@npentrel npentrel force-pushed the docs-update-a3ce53e9-1afa-4e47-8e40-7a3998fb4c11-20250521-113348 branch from 50b6524 to fae3a6e Compare July 17, 2025 14:32
} = JSON.parse(Cookies.get(machineCookieKey)!));
```

For developing your application on localhost, run the following command which will proxy your local app.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should explicitly say that the user's app that they've developed should also have its own server running on its own port in addition to this server being spun up by the Viam CLI and that this is what --app-ul is referring to; that was a key step that I (and @ohEmily) missed when testing this ourselves. Also, a "local development" header/subsection title might be nice?

@bashar-515 bashar-515 self-requested a review July 17, 2025 14:46
Copy link
Member

@bashar-515 bashar-515 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@npentrel npentrel force-pushed the docs-update-a3ce53e9-1afa-4e47-8e40-7a3998fb4c11-20250521-113348 branch from 8f6c9f2 to c95668c Compare July 17, 2025 15:41
@npentrel npentrel merged commit 3bdb631 into main Jul 17, 2025
13 checks passed
@npentrel npentrel deleted the docs-update-a3ce53e9-1afa-4e47-8e40-7a3998fb4c11-20250521-113348 branch July 17, 2025 15:43
Copy link

🔎💬 Inkeep AI search and chat service is syncing content for source 'Viam Docs'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants